Fix GetRequestInfo subresource parsing for proxy/redirect verbs #16570
Conversation
|
Labelling this PR as size/S |
k8s-github-robot
added
the
size/S
|
GCE e2e test build/test passed for commit 7b2aec7f3808f5df5c012c3889d0611e5a3c8a80. |
| @@ -46,6 +46,12 @@ var specialVerbs = map[string]bool{ | |||
| "watch": true, | |||
| } | |||
|
|
|||
| // specialVerbsNoSubresources contains root verbs which do not allow subresources | |||
| var specialVerbsNoSubresources = map[string]bool{ | |||
There was a problem hiding this comment.
This looks like a sets.String
|
Minor comment. lgtm otherwise. |
liggitt
force-pushed
the
proxy_request_info
branch
from
7b2aec7
to
56b7c0d
Compare
|
made both sets.String |
liggitt
force-pushed
the
proxy_request_info
branch
from
56b7c0d
to
600b5e6
Compare
|
GCE e2e test build/test passed for commit 56b7c0ddaf80cb7e4b137d0204050c3e441fe06f. |
|
GCE e2e test build/test passed for commit 600b5e6. |
|
@k8s-bot unit test this |
|
lgtm |
deads2k
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 600b5e6. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 600b5e6. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 600b5e6. |
|
@k8s-bot unit test this |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 600b5e6. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
The root apiserver proxy does not pay attention to subresources, only resources, but
RequestInfoResolver#GetRequestInfois incorrectly considering the first segment of the proxied subpath a subresource.